CodeSOD: Because of the Implication

Even when you're using TypeScript, you're still bound by JavaScript's type system. You're also stuck with its object system, which means that each object is really just a dict, and there's no guarantee that any object has any given key at runtime.

Madison sends us some TypeScript code that is, perhaps not strictly bad, in and of itself, though it certainly contains some badness. It is more of a symptom. It implies a WTF.

 private _filterEmptyValues(value: any): any { const filteredValue = {}; Object.keys(value) .filter(key => { const v = value[key]; if (v === null) { return false; } if (v.von !== undefined || v.bis !== undefined) { return (v.von !== null && v.von !== 'undefined' && v.von !== '') || (v.bis !== null && v.bis !== 'undefined' && v.bis !== ''); } return (v !== 'undefined' && v !== ''); }).forEach(key => { filteredValue[key] = value[key]; }); return filteredValue; }

At a guess, this code is meant to be used as part of prepping objects for being part of a request: clean out unused keys before sending or storing them. And as a core methodology, it's not wrong, and it's pretty similar to your standard StackOverflow solution to the problem. It's just... forcing me to ask some questions.

Let's trace through it. We start by doing an Object.keys to get all the fields on the object. We then filter to remove the empty" ones.

First, if the value is null, that's empty. That makes sense.

Then, if the value is an object which contains a von or bis property, we'll do some more checks. This is a weird definition of empty", but fine. We'll check that they're both non-null, not an empty string, and not... 'undefined'.

Uh oh.

We then do a similar check on the value itself, to ensure it's not an empty string, and not 'undefined'.

What this is telling me is that somewhere in processing, sometimes, the actual string undefined" can be stored, and it's meant to be treated as JavaScript's type undefined. That probably shouldn't be happening, and implies a WTF somewhere else.

Similarly, the von and bis check has to raise a few eyebrows. If an object contains these fields, these fields must contain a value to pass this check. Why? I have no idea.

In the end, this code isn't the WTF itself, it's all the questions that it raises that tell me the shape of the WTF. It's like looking at a black hole: I can't see the object itself, I can only see the effect it has on the space around it.

[Advertisement] Otter - Provision your servers automatically without ever needing to log-in to a command prompt. Get started today!