CodeSOD: intint

Ash's company outsourced to an offshore vendor.

This is an example of what they got back:

public System.Data.DataSet SetQuotaCellTotal(string sessionId, ArrayOfKeyValueOfintintKeyValueOfintint[] cellData, bool modifyTotalSample)

The notable bit in this code is the type ArrayOfKeyValueOfintintKeyValueOfIntint. We're in the world of InternalFrameInternalFrameTitlePaneInternalFrameTitlePaneMaximizeButtonWindowNotFocusedState in terms of names, but this one has the added bonus of being misleading.

This type represents a key/value pair. They're both integers. That's it. It's a pair of ints. As a bonus, they're passing an array of key value pairs into the function- an array of ArrayOfKeyValueOfintintKeyValueOfintint. That's a mouthful.

[Advertisement] BuildMaster allows you to create a self-service release management platform that allows different teams to manage their applications. Explore how!